Unverified Commit fd5894fa authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/vc4: hdmi: Remove clock rate initialization 



Now that the clock driver makes sure we never end up with a rate of 0,
the HDMI driver doesn't need to care anymore.

Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220225143534.405820-13-maxime@cerno.tech
parent 5b6ef06e

drivers/gpu/drm/vc4/vc4_hdmi.c

+0 −13
Original line number Diff line number Diff line
@@ -2902,19 +2902,6 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) 
			vc4_hdmi->disable_4kp60 = true;

	}



	/*

	 * If we boot without any cable connected to the HDMI connector,

	 * the firmware will skip the HSM initialization and leave it

	 * with a rate of 0, resulting in a bus lockup when we're

	 * accessing the registers even if it's enabled.

	 *

	 * Let's put a sensible default at runtime_resume so that we

	 * don't end up in this situation.

	 */

	ret = clk_set_min_rate(vc4_hdmi->hsm_clock, HSM_MIN_CLOCK_FREQ);

	if (ret)

		goto err_put_ddc;



	/*

	 * We need to have the device powered up at this point to call

	 * our reset hook and for the CEC init.