Commit fd54349d authored by Kirill A. Shutemov's avatar Kirill A. Shutemov Committed by Andrew Morton
Browse files

genwqe: fix MAX_ORDER usage 

MAX_ORDER is not inclusive: the maximum allocation order buddy allocator
can deliver is MAX_ORDER-1.

Fix MAX_ORDER usage in genwqe driver.

Link: https://lkml.kernel.org/r/20230315113133.11326-6-kirill.shutemov@linux.intel.com


Signed-off-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 50c00d2c

drivers/misc/genwqe/card_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -443,7 +443,7 @@ static int genwqe_mmap(struct file *filp, struct vm_area_struct *vma) 
	if (vsize == 0)

		return -EINVAL;



	if (get_order(vsize) > MAX_ORDER)

	if (get_order(vsize) >= MAX_ORDER)

		return -ENOMEM;



	dma_map = kzalloc(sizeof(struct dma_mapping), GFP_KERNEL);

drivers/misc/genwqe/card_utils.c

+1 −1
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ int genwqe_alloc_sync_sgl(struct genwqe_dev *cd, struct genwqe_sgl *sgl, 
	sgl->write = write;

	sgl->sgl_size = genwqe_sgl_size(sgl->nr_pages);



	if (get_order(sgl->sgl_size) > MAX_ORDER) {

	if (get_order(sgl->sgl_size) >= MAX_ORDER) {

		dev_err(&pci_dev->dev,

			"[%s] err: too much memory requested!\n", __func__);

		return ret;