Commit fd3dc165 authored by Anirudh Venkataramanan's avatar Anirudh Venkataramanan Committed by Tony Nguyen
Browse files

ice: Remove unnecessary checker loop 



The loop checking for PF VSI doesn't make any sense. The VSI type
backing the netdev passed to ice_set_link_ksettings will always be
of type ICE_PF_VSI. Remove it.

Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent d348d517

drivers/net/ethernet/intel/ice/ice_ethtool.c

+1 −9
Original line number Diff line number Diff line
@@ -2198,8 +2198,8 @@ ice_set_link_ksettings(struct net_device *netdev, 
	struct ethtool_link_ksettings safe_ks, copy_ks;

	struct ice_aqc_get_phy_caps_data *abilities;

	u8 autoneg, timeout = TEST_SET_BITS_TIMEOUT;

	u16 adv_link_speed, curr_link_speed, idx;

	struct ice_aqc_set_phy_cfg_data config;

	u16 adv_link_speed, curr_link_speed;

	struct ice_pf *pf = np->vsi->back;

	struct ice_port_info *p;

	u8 autoneg_changed = 0;
@@ -2214,14 +2214,6 @@ ice_set_link_ksettings(struct net_device *netdev, 
	if (!p)

		return -EOPNOTSUPP;



	/* Check if this is LAN VSI */

	ice_for_each_vsi(pf, idx)

		if (pf->vsi[idx]->type == ICE_VSI_PF) {

			if (np->vsi != pf->vsi[idx])

				return -EOPNOTSUPP;

			break;

		}



	if (p->phy.media_type != ICE_MEDIA_BASET &&

	    p->phy.media_type != ICE_MEDIA_FIBER &&

	    p->phy.media_type != ICE_MEDIA_BACKPLANE &&