Commit fd2c930c authored by ruanjinjie's avatar ruanjinjie Committed by Greg Kroah-Hartman
Browse files

misc: tifm: fix possible memory leak in tifm_7xx1_switch_media() 



If device_register() returns error in tifm_7xx1_switch_media(),
name of kobject which is allocated in dev_set_name() called in device_add()
is leaked.

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Fixes: 2428a8fe ("tifm: move common device management tasks from tifm_7xx1 to tifm_core")
Signed-off-by: default avatarruanjinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20221117064725.3478402-1-ruanjinjie@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1dbb4f02

drivers/misc/tifm_7xx1.c

+1 −1
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ static void tifm_7xx1_switch_media(struct work_struct *work) 
				spin_unlock_irqrestore(&fm->lock, flags);

			}

			if (sock)

				tifm_free_device(&sock->dev);

				put_device(&sock->dev);

		}

		spin_lock_irqsave(&fm->lock, flags);

	}