Commit fcfc8be1 authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by Trond Myklebust
Browse files

NFSv4.2 fix problems with __nfs42_ssc_open 



A destination server while doing a COPY shouldn't accept using the
passed in filehandle if its not a regular filehandle.

If alloc_file_pseudo() has failed, we need to decrement a reference
on the newly created inode, otherwise it leaks.

Reported-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Fixes: ec4b0925 ("NFS: inter ssc open")
Signed-off-by: default avatarOlga Kornievskaia <kolga@netapp.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent f16857e6

fs/nfs/nfs4file.c

+6 −0
Original line number Diff line number Diff line
@@ -340,6 +340,11 @@ static struct file *__nfs42_ssc_open(struct vfsmount *ss_mnt, 
		goto out;

	}



	if (!S_ISREG(fattr->mode)) {

		res = ERR_PTR(-EBADF);

		goto out;

	}



	res = ERR_PTR(-ENOMEM);

	len = strlen(SSC_READ_NAME_BODY) + 16;

	read_name = kzalloc(len, GFP_KERNEL);
@@ -357,6 +362,7 @@ static struct file *__nfs42_ssc_open(struct vfsmount *ss_mnt, 
				     r_ino->i_fop);

	if (IS_ERR(filep)) {

		res = ERR_CAST(filep);

		iput(r_ino);

		goto out_free_name;

	}