Commit fcd53c8a authored by Zqiang's avatar Zqiang Committed by Paul E. McKenney
Browse files

rcu-tasks: Convert RCU_LOCKDEP_WARN() to WARN_ONCE() 



Kernels built with CONFIG_PROVE_RCU=y and CONFIG_DEBUG_LOCK_ALLOC=y
attempt to emit a warning when the synchronize_rcu_tasks_generic()
function is called during early boot while the rcu_scheduler_active
variable is RCU_SCHEDULER_INACTIVE.  However the warnings is not
actually be printed because the debug_lockdep_rcu_enabled() returns
false, exactly because the rcu_scheduler_active variable is still equal
to RCU_SCHEDULER_INACTIVE.

This commit therefore replaces RCU_LOCKDEP_WARN() with WARN_ONCE()
to force these warnings to actually be printed.

Signed-off-by: default avatarZqiang <qiang1.zhang@intel.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 568035b0

kernel/rcu/tasks.h

+1 −1
Original line number Diff line number Diff line
@@ -560,7 +560,7 @@ static int __noreturn rcu_tasks_kthread(void *arg) 
static void synchronize_rcu_tasks_generic(struct rcu_tasks *rtp)

{

	/* Complain if the scheduler has not started.  */

	RCU_LOCKDEP_WARN(rcu_scheduler_active == RCU_SCHEDULER_INACTIVE,

	WARN_ONCE(rcu_scheduler_active == RCU_SCHEDULER_INACTIVE,

			 "synchronize_rcu_tasks called too soon");



	// If the grace-period kthread is running, use it.