Commit fcb82839 authored by kernel test robot's avatar kernel test robot Committed by Marc Zyngier
Browse files

KVM: arm64: Fix boolreturn.cocci warnings 



arch/arm64/kvm/mmu.c:1114:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool
arch/arm64/kvm/mmu.c:1084:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool
arch/arm64/kvm/mmu.c:1127:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool
arch/arm64/kvm/mmu.c:1070:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: cd4c7183 ("KVM: arm64: Convert to the gfn-based MMU notifier callbacks")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarkernel test robot <lkp@intel.com>
Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210426223357.GA45871@cd4295a34ed8
parent e44b49f6

arch/arm64/kvm/mmu.c

+6 −6
Original line number Diff line number Diff line
@@ -1156,13 +1156,13 @@ int kvm_handle_guest_abort(struct kvm_vcpu *vcpu) 
bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range)

{

	if (!kvm->arch.mmu.pgt)

		return 0;

		return false;



	__unmap_stage2_range(&kvm->arch.mmu, range->start << PAGE_SHIFT,

			     (range->end - range->start) << PAGE_SHIFT,

			     range->may_block);



	return 0;

	return false;

}



bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
@@ -1170,7 +1170,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) 
	kvm_pfn_t pfn = pte_pfn(range->pte);



	if (!kvm->arch.mmu.pgt)

		return 0;

		return false;



	WARN_ON(range->end - range->start != 1);
@@ -1190,7 +1190,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) 
			       PAGE_SIZE, __pfn_to_phys(pfn),

			       KVM_PGTABLE_PROT_R, NULL);



	return 0;

	return false;

}



bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
@@ -1200,7 +1200,7 @@ bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range) 
	pte_t pte;



	if (!kvm->arch.mmu.pgt)

		return 0;

		return false;



	WARN_ON(size != PAGE_SIZE && size != PMD_SIZE && size != PUD_SIZE);
@@ -1213,7 +1213,7 @@ bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range) 
bool kvm_test_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range)

{

	if (!kvm->arch.mmu.pgt)

		return 0;

		return false;



	return kvm_pgtable_stage2_is_young(kvm->arch.mmu.pgt,

					   range->start << PAGE_SHIFT);