Commit fca05389 authored by Fabio Estevam's avatar Fabio Estevam Committed by Shawn Guo
Browse files

arm64: dts: imx8m-venice: Remove incorrect 'uart-has-rtscts' 



The following build warnings are seen when running:

make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: cts-gpios: False schema does not allow [[33, 3, 1]]
	From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb: serial@30860000: rts-gpios: False schema does not allow [[33, 5, 1]]
	From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
...

The imx8m Venice Gateworks boards do not expose the UART RTS and CTS
as native UART pins, so 'uart-has-rtscts' should not be used.

Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
detected by serial.yaml.

Fix the problem by removing the incorrect 'uart-has-rtscts' property.

Fixes: 27c8f4cc ("arm64: dts: imx8mm-venice-gw72xx-0x: add dt overlays for serial modes")
Fixes: d9a9a7cf ("arm64: dts: imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs")
Fixes: 870f645b ("arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support")
Signed-off-by: default avatarFabio Estevam <festevam@denx.de>
Acked-by: default avatarTim Harvey <tharvey@gateworks.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 2f440c4f

arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso

+0 −1
Original line number Diff line number Diff line
@@ -33,7 +33,6 @@ 
	pinctrl-0 = <&pinctrl_uart2>;

	rts-gpios = <&gpio5 29 GPIO_ACTIVE_LOW>;

	cts-gpios = <&gpio5 28 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};

arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtso

+0 −1
Original line number Diff line number Diff line
@@ -33,7 +33,6 @@ 
	pinctrl-0 = <&pinctrl_uart2>;

	rts-gpios = <&gpio5 29 GPIO_ACTIVE_LOW>;

	cts-gpios = <&gpio5 28 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};

arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi

+0 −1
Original line number Diff line number Diff line
@@ -222,7 +222,6 @@ 
	pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_bten>;

	cts-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;

	rts-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";



	bluetooth {

arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts

+0 −3
Original line number Diff line number Diff line
@@ -733,7 +733,6 @@ 
	dtr-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;

	dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;

	dcd-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};
@@ -749,7 +748,6 @@ 
	pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;

	cts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;

	rts-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};
@@ -758,7 +756,6 @@ 
	pinctrl-0 = <&pinctrl_uart4>, <&pinctrl_uart4_gpio>;

	cts-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;

	rts-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};

arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts

+0 −3
Original line number Diff line number Diff line
@@ -664,7 +664,6 @@ 
	pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>;

	rts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;

	cts-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};
@@ -681,7 +680,6 @@ 
	pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;

	rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;

	cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";



	bluetooth {
@@ -699,7 +697,6 @@ 
	dtr-gpios = <&gpio4 3 GPIO_ACTIVE_LOW>;

	dsr-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;

	dcd-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>;

	uart-has-rtscts;

	status = "okay";

};