Unverified Commit fc8d29e2 authored by Arthur Grillo's avatar Arthur Grillo Committed by Javier Martinez Canillas
Browse files

drm: selftest: convert drm_mm selftest to KUnit 



Considering the current adoption of the KUnit framework, convert the
DRM mm selftest to the KUnit API.

Signed-off-by: default avatarArthur Grillo <arthur.grillo@usp.br>
Tested-by: default avatarDavid Gow <davidgow@google.com>
Acked-by: default avatarDaniel Latypov <dlatypov@google.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarMaíra Canal <maira.canal@usp.br>
Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220708203052.236290-10-maira.canal@usp.br
parent 932da861

Documentation/gpu/todo.rst

+0 −11
Original line number Diff line number Diff line
@@ -617,17 +617,6 @@ Contact: Javier Martinez Canillas <javierm@redhat.com> 


Level: Intermediate



Convert Kernel Selftests (kselftest) to KUnit tests when appropriate

--------------------------------------------------------------------



Many of the `Kselftest <https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html>`_

tests in DRM could be converted to Kunit tests instead, since that framework

is more suitable for unit testing.



Contact: Javier Martinez Canillas <javierm@redhat.com>



Level: Starter



Enable trinity for DRM

----------------------

drivers/gpu/drm/Kconfig

+0 −20
Original line number Diff line number Diff line
@@ -50,26 +50,6 @@ config DRM_DEBUG_MM 


	  If in doubt, say "N".



config DRM_DEBUG_SELFTEST

	tristate "kselftests for DRM"

	depends on DRM

	depends on DEBUG_KERNEL

	select PRIME_NUMBERS

	select DRM_DISPLAY_DP_HELPER

	select DRM_DISPLAY_HELPER

	select DRM_LIB_RANDOM

	select DRM_KMS_HELPER

	select DRM_BUDDY

	select DRM_EXPORT_FOR_TESTS if m

	default n

	help

	  This option provides kernel modules that can be used to run

	  various selftests on parts of the DRM api. This option is not

	  useful for distributions or general kernels, but only for kernel

	  developers working on DRM and associated drivers.



	  If in doubt, say "N".



config DRM_KUNIT_TEST

	tristate "KUnit tests for DRM" if !KUNIT_ALL_TESTS

	depends on DRM && KUNIT

drivers/gpu/drm/Makefile

+0 −1
Original line number Diff line number Diff line
@@ -75,7 +75,6 @@ obj-$(CONFIG_DRM_KMS_HELPER) += drm_kms_helper.o 
# Drivers and the rest

#



obj-$(CONFIG_DRM_DEBUG_SELFTEST) += selftests/

obj-$(CONFIG_DRM_KUNIT_TEST) += tests/



obj-$(CONFIG_DRM_MIPI_DBI) += drm_mipi_dbi.o

drivers/gpu/drm/selftests/Makefile

deleted100644 → 0
+0 −2
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

obj-$(CONFIG_DRM_DEBUG_SELFTEST) += test-drm_mm.o

drivers/gpu/drm/selftests/drm_mm_selftests.h

deleted100644 → 0
+0 −28
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

/* List each unit test as selftest(name, function)

 *

 * The name is used as both an enum and expanded as igt__name to create

 * a module parameter. It must be unique and legal for a C identifier.

 *

 * Tests are executed in order by igt/drm_mm

 */

selftest(sanitycheck, igt_sanitycheck) /* keep first (selfcheck for igt) */

selftest(init, igt_init)

selftest(debug, igt_debug)

selftest(reserve, igt_reserve)

selftest(insert, igt_insert)

selftest(replace, igt_replace)

selftest(insert_range, igt_insert_range)

selftest(align, igt_align)

selftest(frag, igt_frag)

selftest(align32, igt_align32)

selftest(align64, igt_align64)

selftest(evict, igt_evict)

selftest(evict_range, igt_evict_range)

selftest(bottomup, igt_bottomup)

selftest(lowest, igt_lowest)

selftest(topdown, igt_topdown)

selftest(highest, igt_highest)

selftest(color, igt_color)

selftest(color_evict, igt_color_evict)

selftest(color_evict_range, igt_color_evict_range)