Commit fc7a6209 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

bus: Make remove callback return void 



The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.

This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.

With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.

Reviewed-by: Tom Rix <trix@redhat.com> (For fpga)
Reviewed-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com> (For drivers/s390 and drivers/vfio)
Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> (For ARM, Amba and related parts)
Acked-by: default avatarMark Brown <broonie@kernel.org>
Acked-by: Chen-Yu Tsai <wens@csie.org> (for sunxi-rsb)
Acked-by: default avatarPali Rohár <pali@kernel.org>
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> (for media)
Acked-by: Hans de Goede <hdegoede@redhat.com> (For drivers/platform)
Acked-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Acked-By: default avatarVinod Koul <vkoul@kernel.org>
Acked-by: Juergen Gross <jgross@suse.com> (For xen)
Acked-by: Lee Jones <lee.jones@linaro.org> (For mfd)
Acked-by: Johannes Thumshirn <jth@kernel.org> (For mcb)
Acked-by: default avatarJohan Hovold <johan@kernel.org>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (For slimbus)
Acked-by: Kirti Wankhede <kwankhede@nvidia.com> (For vfio)
Acked-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> (For ulpi and typec)
Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> (For ipack)
Acked-by: Geoff Levand <geoff@infradead.org> (For ps3)
Acked-by: Yehezkel Bernat <YehezkelShB@gmail.com> (For thunderbolt)
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> (For intel_th)
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net> (For pcmcia)
Acked-by: Rafael J. Wysocki <rafael@kernel.org> (For ACPI)
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> (rpmsg and apr)
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> (For intel-ish-hid)
Acked-by: Dan Williams <dan.j.williams@intel.com> (For CXL, DAX, and NVDIMM)
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> (For isa)
Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (For firewire)
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> (For hid)
Acked-by: Thorsten Scherer <t.scherer@eckelmann.de> (For siox)
Acked-by: Sven Van Asbroeck <TheSven73@gmail.com> (For anybuss)
Acked-by: Ulf Hansson <ulf.hansson@linaro.org> (For MMC)
Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Acked-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Acked-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: default avatarFinn Thain <fthain@linux-m68k.org>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 15f83bb0

arch/arm/common/locomo.c

+1 −2
Original line number Diff line number Diff line
@@ -834,14 +834,13 @@ static int locomo_bus_probe(struct device *dev) 
	return ret;

}



static int locomo_bus_remove(struct device *dev)

static void locomo_bus_remove(struct device *dev)

{

	struct locomo_dev *ldev = LOCOMO_DEV(dev);

	struct locomo_driver *drv = LOCOMO_DRV(dev->driver);



	if (drv->remove)

		drv->remove(ldev);

	return 0;

}



struct bus_type locomo_bus_type = {

arch/arm/common/sa1111.c

+1 −3
Original line number Diff line number Diff line
@@ -1364,15 +1364,13 @@ static int sa1111_bus_probe(struct device *dev) 
	return ret;

}



static int sa1111_bus_remove(struct device *dev)

static void sa1111_bus_remove(struct device *dev)

{

	struct sa1111_dev *sadev = to_sa1111_device(dev);

	struct sa1111_driver *drv = SA1111_DRV(dev->driver);



	if (drv->remove)

		drv->remove(sadev);



	return 0;

}



struct bus_type sa1111_bus_type = {

arch/arm/mach-rpc/ecard.c

+1 −3
Original line number Diff line number Diff line
@@ -1052,7 +1052,7 @@ static int ecard_drv_probe(struct device *dev) 
	return ret;

}



static int ecard_drv_remove(struct device *dev)

static void ecard_drv_remove(struct device *dev)

{

	struct expansion_card *ec = ECARD_DEV(dev);

	struct ecard_driver *drv = ECARD_DRV(dev->driver);
@@ -1067,8 +1067,6 @@ static int ecard_drv_remove(struct device *dev) 
	ec->ops = &ecard_default_ops;

	barrier();

	ec->irq_data = NULL;



	return 0;

}



/*

arch/mips/sgi-ip22/ip22-gio.c

+1 −2
Original line number Diff line number Diff line
@@ -143,14 +143,13 @@ static int gio_device_probe(struct device *dev) 
	return error;

}



static int gio_device_remove(struct device *dev)

static void gio_device_remove(struct device *dev)

{

	struct gio_device *gio_dev = to_gio_device(dev);

	struct gio_driver *drv = to_gio_driver(dev->driver);



	if (dev->driver && drv->remove)

		drv->remove(gio_dev);

	return 0;

}



static void gio_device_shutdown(struct device *dev)

arch/parisc/kernel/drivers.c

+2 −3
Original line number Diff line number Diff line
@@ -133,14 +133,13 @@ static int parisc_driver_probe(struct device *dev) 
	return rc;

}



static int __exit parisc_driver_remove(struct device *dev)

static void __exit parisc_driver_remove(struct device *dev)

{

	struct parisc_device *pa_dev = to_parisc_device(dev);

	struct parisc_driver *pa_drv = to_parisc_driver(dev->driver);



	if (pa_drv->remove)

		pa_drv->remove(pa_dev);



	return 0;

}