Commit fc75e4fc authored by Cai Huoqing's avatar Cai Huoqing Committed by Thierry Reding
Browse files

drm/tegra: dsi: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent d4281c01

drivers/gpu/drm/tegra/dsi.c

+12 −16
Original line number Diff line number Diff line
@@ -1589,28 +1589,24 @@ static int tegra_dsi_probe(struct platform_device *pdev) 
	}



	dsi->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(dsi->clk)) {

		dev_err(&pdev->dev, "cannot get DSI clock\n");

		return PTR_ERR(dsi->clk);

	}

	if (IS_ERR(dsi->clk))

		return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk),

				     "cannot get DSI clock\n");



	dsi->clk_lp = devm_clk_get(&pdev->dev, "lp");

	if (IS_ERR(dsi->clk_lp)) {

		dev_err(&pdev->dev, "cannot get low-power clock\n");

		return PTR_ERR(dsi->clk_lp);

	}

	if (IS_ERR(dsi->clk_lp))

		return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_lp),

				     "cannot get low-power clock\n");



	dsi->clk_parent = devm_clk_get(&pdev->dev, "parent");

	if (IS_ERR(dsi->clk_parent)) {

		dev_err(&pdev->dev, "cannot get parent clock\n");

		return PTR_ERR(dsi->clk_parent);

	}

	if (IS_ERR(dsi->clk_parent))

		return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_parent),

				     "cannot get parent clock\n");



	dsi->vdd = devm_regulator_get(&pdev->dev, "avdd-dsi-csi");

	if (IS_ERR(dsi->vdd)) {

		dev_err(&pdev->dev, "cannot get VDD supply\n");

		return PTR_ERR(dsi->vdd);

	}

	if (IS_ERR(dsi->vdd))

		return dev_err_probe(&pdev->dev, PTR_ERR(dsi->vdd),

				     "cannot get VDD supply\n");



	err = tegra_dsi_setup_clocks(dsi);

	if (err < 0) {