Commit fc423f29 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: bcm-kona: Use pwmchip_add() instead of pwmchip_add_with_polarity() 



The only side effect of this change is that pwm->state.polarity is
initialized to PWM_POLARITY_NORMAL instead of PWM_POLARITY_INVERSED.
However all other members of pwm->state are uninitialized and consumers
are expected to provide the right polarity (either by setting it explicitly
or by using a helper like pwm_init_state() that overwrites .polarity
anyhow with a value independent of the initial value).

The eventual goal is to remove pwmchip_add_with_polarity() and so simplify
the data flow in the PWM core.

Signed-off-by: default avatarUwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 9f0f6107

drivers/pwm/pwm-bcm-kona.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ static int kona_pwmc_probe(struct platform_device *pdev) 


	clk_disable_unprepare(kp->clk);



	ret = pwmchip_add_with_polarity(&kp->chip, PWM_POLARITY_INVERSED);

	ret = pwmchip_add(&kp->chip);

	if (ret < 0)

		dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);