Commit fc3d3369 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Greg Kroah-Hartman
Browse files

staging: hi6421-spmi-pmic: use devm_request_threaded_irq() 



Use devm_request_threaded_irq() in order to simplify the
driver.

Suggested-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/b47827c3466eeef3a7de6ac56b1fe93b5ff84e30.1624606660.git.mchehab+huawei@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cb5d92d1

drivers/staging/hikey9xx/hi6421-spmi-pmic.c

+5 −11
Original line number Diff line number Diff line
@@ -250,7 +250,9 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) 
		ddata->irqs[i] = virq;

	}



	ret = request_threaded_irq(ddata->irq, hi6421_spmi_irq_handler, NULL,

	ret = devm_request_threaded_irq(dev,

					ddata->irq, hi6421_spmi_irq_handler,

					NULL,

				        IRQF_TRIGGER_LOW | IRQF_SHARED | IRQF_NO_SUSPEND,

				        "pmic", ddata);

	if (ret < 0) {
@@ -270,13 +272,6 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev) 
	return ret;

}



static void hi6421_spmi_pmic_remove(struct spmi_device *pdev)

{

	struct hi6421_spmi_pmic *ddata = dev_get_drvdata(&pdev->dev);



	free_irq(ddata->irq, ddata);

}



static const struct of_device_id pmic_spmi_id_table[] = {

	{ .compatible = "hisilicon,hi6421-spmi" },

	{ }
@@ -289,7 +284,6 @@ static struct spmi_driver hi6421_spmi_pmic_driver = { 
		.of_match_table = pmic_spmi_id_table,

	},

	.probe	= hi6421_spmi_pmic_probe,

	.remove	= hi6421_spmi_pmic_remove,

};

module_spmi_driver(hi6421_spmi_pmic_driver);