Commit fc1d3901 authored by José Expósito's avatar José Expósito Committed by Hongbo Li
Browse files

HID: logitech-dj: Fix memory leak in logi_dj_recv_switch_to_dj_mode() 

stable inclusion
from stable-v6.6.35
commit f677ca8cfefee2a729ca315f660cd4868abdf8de
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IAD0B8
CVE: CVE-2024-40934

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f677ca8cfefee2a729ca315f660cd4868abdf8de



--------------------------------

[ Upstream commit ce3af2ee95170b7d9e15fff6e500d67deab1e7b3 ]

Fix a memory leak on logi_dj_recv_send_report() error path.

Fixes: 6f20d326 ("HID: logitech-dj: Fix error handling in logi_dj_recv_switch_to_dj_mode()")
Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarHongbo Li <lihongbo22@huawei.com>
parent 3c62a9a7

drivers/hid/hid-logitech-dj.c

+3 −1
Original line number Diff line number Diff line
@@ -1284,9 +1284,11 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_receiver_dev *djrcv_dev, 
		 */

		msleep(50);



		if (retval)

		if (retval) {

			kfree(dj_report);

			return retval;

		}

	}



	/*

	 * Magical bits to set up hidpp notifications when the dj devices