Commit fc1bd51d authored by Paulo Alcantara's avatar Paulo Alcantara Committed by Steve French
Browse files

smb: client: fix warning in cifs_match_super() 

Fix potential dereference of ERR_PTR @tlink as reported by kernel test
robot

  fs/smb/client/connect.c:2775 cifs_match_super() error: 'tlink'
  dereferencing possible ERR_PTR()

Link: https://lore.kernel.org/all/202306170124.CtQqzf0I-lkp@intel.com/


Signed-off-by: default avatarPaulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent dc765027

fs/smb/client/connect.c

+3 −2
Original line number Diff line number Diff line
@@ -2767,8 +2767,9 @@ cifs_match_super(struct super_block *sb, void *data) 
	}



	tlink = cifs_get_tlink(cifs_sb_master_tlink(cifs_sb));

	if (tlink == NULL) {

		/* can not match superblock if tlink were ever null */

	if (IS_ERR_OR_NULL(tlink)) {

		pr_warn_once("%s: skip super matching due to bad tlink(%p)\n",

			     __func__, tlink);

		spin_unlock(&cifs_tcp_ses_lock);

		return 0;

	}