Commit fc186d0a authored by Xin Long's avatar Xin Long Committed by Jakub Kicinski
Browse files

net: ixgbevf: use skb_csum_is_sctp instead of protocol check 



Using skb_csum_is_sctp is a easier way to validate it's a SCTP CRC
checksum offload packet, and yet it also makes ixgbevf support SCTP
CRC checksum offload for UDP and GRE encapped packets, just as it
does in igb driver.

Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Reviewed-by: default avatarAlexander Duyck <alexanderduyck@fb.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f8c4b01d

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

+1 −13
Original line number Diff line number Diff line
@@ -3843,15 +3843,6 @@ static int ixgbevf_tso(struct ixgbevf_ring *tx_ring, 
	return 1;

}



static inline bool ixgbevf_ipv6_csum_is_sctp(struct sk_buff *skb)

{

	unsigned int offset = 0;



	ipv6_find_hdr(skb, &offset, IPPROTO_SCTP, NULL, NULL);



	return offset == skb_checksum_start_offset(skb);

}



static void ixgbevf_tx_csum(struct ixgbevf_ring *tx_ring,

			    struct ixgbevf_tx_buffer *first,

			    struct ixgbevf_ipsec_tx_data *itd)
@@ -3872,10 +3863,7 @@ static void ixgbevf_tx_csum(struct ixgbevf_ring *tx_ring, 
		break;

	case offsetof(struct sctphdr, checksum):

		/* validate that this is actually an SCTP request */

		if (((first->protocol == htons(ETH_P_IP)) &&

		     (ip_hdr(skb)->protocol == IPPROTO_SCTP)) ||

		    ((first->protocol == htons(ETH_P_IPV6)) &&

		     ixgbevf_ipv6_csum_is_sctp(skb))) {

		if (skb_csum_is_sctp(skb)) {

			type_tucmd = IXGBE_ADVTXD_TUCMD_L4T_SCTP;

			break;

		}