Commit fc06b286 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by David S. Miller
Browse files

net: dsa: Add missing of_node_put() in dsa_port_link_register_of 



The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.
of_node_put() will check for NULL value.

Fixes: a20f9970 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d48fea84

net/dsa/port.c

+2 −0
Original line number Diff line number Diff line
@@ -1620,8 +1620,10 @@ int dsa_port_link_register_of(struct dsa_port *dp) 
			if (ds->ops->phylink_mac_link_down)

				ds->ops->phylink_mac_link_down(ds, port,

					MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);

			of_node_put(phy_np);

			return dsa_port_phylink_register(dp);

		}

		of_node_put(phy_np);

		return 0;

	}