Commit fbc97de8 authored by Huang Guobin's avatar Huang Guobin Committed by David S. Miller
Browse files

tipc: Use is_broadcast_ether_addr() instead of memcmp() 

Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarHuang Guobin <huangguobin4@huawei.com>
Acked-by: default avatarYing Xue <ying.xue@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6c09b484

net/tipc/eth_media.c

+1 −3
Original line number Diff line number Diff line
@@ -62,12 +62,10 @@ static int tipc_eth_raw2addr(struct tipc_bearer *b, 
			     struct tipc_media_addr *addr,

			     char *msg)

{

	char bcast_mac[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};



	memset(addr, 0, sizeof(*addr));

	ether_addr_copy(addr->value, msg);

	addr->media_id = TIPC_MEDIA_TYPE_ETH;

	addr->broadcast = !memcmp(addr->value, bcast_mac, ETH_ALEN);

	addr->broadcast = is_broadcast_ether_addr(addr->value);

	return 0;

}