Commit fbbc94d8 authored by Sander Vanheule's avatar Sander Vanheule Committed by Yury Norov
Browse files

lib/test_cpumask: fix cpu_possible_mask last test 

Since cpumask_first() on the cpu_possible_mask must return at most
nr_cpu_ids - 1 for a valid result, cpumask_last() cannot return anything
larger than this value.  As test_cpumask_weight() also verifies that the
total weight of cpu_possible_mask must equal nr_cpu_ids, the last bit
set in this mask must be at nr_cpu_ids - 1.

Fixes: c41e8866 ("lib/test: introduce cpumask KUnit test suite")
Link: https://lore.kernel.org/lkml/346cb279-8e75-24b0-7d12-9803f2b41c73@riseup.net/


Reported-by: default avatarMaíra Canal <mairacanal@riseup.net>
Signed-off-by: default avatarSander Vanheule <sander@svanheule.net>
Tested-by: default avatarMaíra Canal <mairacanal@riseup.net>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Acked-by: default avatarYury Norov <yury.norov@gmail.com>
Signed-off-by: default avatarYury Norov <yury.norov@gmail.com>
parent 6afd9db6

lib/test_cpumask.c

+1 −1
Original line number Diff line number Diff line
@@ -73,7 +73,7 @@ static void test_cpumask_first(struct kunit *test) 
static void test_cpumask_last(struct kunit *test)

{

	KUNIT_EXPECT_LE(test, nr_cpumask_bits, cpumask_last(&mask_empty));

	KUNIT_EXPECT_EQ(test, nr_cpumask_bits - 1, cpumask_last(cpu_possible_mask));

	KUNIT_EXPECT_EQ(test, nr_cpu_ids - 1, cpumask_last(cpu_possible_mask));

}



static void test_cpumask_next(struct kunit *test)