Commit fbb80d5a authored by Zhen Lei's avatar Zhen Lei Committed by Marc Zyngier
Browse files

irqchip: Remove redundant error printing 



When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210511125428.6108-2-thunder.leizhen@huawei.com
parent 5b44955d

drivers/irqchip/irq-mvebu-icu.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -359,10 +359,8 @@ static int mvebu_icu_probe(struct platform_device *pdev) 




	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	icu->base = devm_ioremap_resource(&pdev->dev, res);

	icu->base = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(icu->base)) {

	if (IS_ERR(icu->base))

		dev_err(&pdev->dev, "Failed to map icu base address.\n");

		return PTR_ERR(icu->base);

		return PTR_ERR(icu->base);

	}





	/*

	/*

	 * Legacy bindings: ICU is one node with one MSI parent: force manually

	 * Legacy bindings: ICU is one node with one MSI parent: force manually

drivers/irqchip/irq-mvebu-sei.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -384,10 +384,8 @@ static int mvebu_sei_probe(struct platform_device *pdev) 




	sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	sei->base = devm_ioremap_resource(sei->dev, sei->res);

	sei->base = devm_ioremap_resource(sei->dev, sei->res);

	if (IS_ERR(sei->base)) {

	if (IS_ERR(sei->base))

		dev_err(sei->dev, "Failed to remap SEI resource\n");

		return PTR_ERR(sei->base);

		return PTR_ERR(sei->base);

	}





	/* Retrieve the SEI capabilities with the interrupt ranges */

	/* Retrieve the SEI capabilities with the interrupt ranges */

	sei->caps = of_device_get_match_data(&pdev->dev);

	sei->caps = of_device_get_match_data(&pdev->dev);

drivers/irqchip/irq-stm32-exti.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev) 




	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	host_data->base = devm_ioremap_resource(dev, res);

	host_data->base = devm_ioremap_resource(dev, res);

	if (IS_ERR(host_data->base)) {

	if (IS_ERR(host_data->base))

		dev_err(dev, "Unable to map registers\n");

		return PTR_ERR(host_data->base);

		return PTR_ERR(host_data->base);

	}





	for (i = 0; i < drv_data->bank_nr; i++)

	for (i = 0; i < drv_data->bank_nr; i++)

		stm32_exti_chip_init(host_data, i, np);

		stm32_exti_chip_init(host_data, i, np);