Commit fb908850 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: scsi_dh_alua: Set 'transitioning' state on Unit Attention 

We should be setting the 'transitioning' ALUA state once we get a Unit
Attention indicating the array is in transitioning.  There are arrays which
cannot respond to an RTPG while in transitioning, and others have issues
correctly reporting the state.  So better to set the state during Unit
Attention handling and wait for TUR / RTPG to run its course.

Link: https://lore.kernel.org/r/20200930080256.90964-4-hare@suse.de


Reviewed-by: default avatarEwan D. Milne <emilne@redhat.com>
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 268940b8

drivers/scsi/device_handler/scsi_dh_alua.c

+8 −0
Original line number Diff line number Diff line
@@ -408,12 +408,20 @@ static char print_alua_state(unsigned char state) 
static int alua_check_sense(struct scsi_device *sdev,

			    struct scsi_sense_hdr *sense_hdr)

{

	struct alua_dh_data *h = sdev->handler_data;

	struct alua_port_group *pg;



	switch (sense_hdr->sense_key) {

	case NOT_READY:

		if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0a) {

			/*

			 * LUN Not Accessible - ALUA state transition

			 */

			rcu_read_lock();

			pg = rcu_dereference(h->pg);

			if (pg)

				pg->state = SCSI_ACCESS_STATE_TRANSITIONING;

			rcu_read_unlock();

			alua_check(sdev, false);

			return NEEDS_RETRY;

		}