Commit fb7da771 authored by Daniel Golle's avatar Daniel Golle Committed by Jakub Kicinski
Browse files

net: ethernet: mtk_eth_soc: fix wrong use of new helper function 



In function mtk_foe_entry_set_vlan() the call to field accessor macro
FIELD_GET(MTK_FOE_IB1_BIND_VLAN_LAYER, entry->ib1)
has been wrongly replaced by
mtk_prep_ib1_vlan_layer(eth, entry->ib1)

Use correct helper function mtk_get_ib1_vlan_layer instead.

Reported-by: default avatarChen Minqiang <ptpt52@gmail.com>
Fixes: 03a3180e ("net: ethernet: mtk_eth_soc: introduce flow offloading support for mt7986")
Signed-off-by: default avatarDaniel Golle <daniel@makrotopia.org>
Acked-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Link: https://lore.kernel.org/r/YzBp+Kk04CFDys4L@makrotopia.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5591b021

drivers/net/ethernet/mediatek/mtk_ppe.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -337,7 +337,7 @@ int mtk_foe_entry_set_vlan(struct mtk_eth *eth, struct mtk_foe_entry *entry, 
{

{

	struct mtk_foe_mac_info *l2 = mtk_foe_entry_l2(eth, entry);

	struct mtk_foe_mac_info *l2 = mtk_foe_entry_l2(eth, entry);





	switch (mtk_prep_ib1_vlan_layer(eth, entry->ib1)) {

	switch (mtk_get_ib1_vlan_layer(eth, entry->ib1)) {

	case 0:

	case 0:

		entry->ib1 |= mtk_get_ib1_vlan_tag_mask(eth) |

		entry->ib1 |= mtk_get_ib1_vlan_tag_mask(eth) |

			      mtk_prep_ib1_vlan_layer(eth, 1);

			      mtk_prep_ib1_vlan_layer(eth, 1);