Commit fb7b9b02 authored by Vincent Fu's avatar Vincent Fu Committed by Jens Axboe
Browse files

kyber: make trace_block_rq call consistent with documentation 



The kyber ioscheduler calls trace_block_rq_insert() *after* the request
is added to the queue but the documentation for trace_block_rq_insert()
says that the call should be made *before* the request is added to the
queue.  Move the tracepoint for the kyber ioscheduler so that it is
consistent with the documentation.

Signed-off-by: default avatarVincent Fu <vincent.fu@samsung.com>
Link: https://lore.kernel.org/r/20210804194913.10497-1-vincent.fu@samsung.com


Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2e9fb2c1

block/kyber-iosched.c

+1 −1
Original line number Diff line number Diff line
@@ -596,13 +596,13 @@ static void kyber_insert_requests(struct blk_mq_hw_ctx *hctx, 
		struct list_head *head = &kcq->rq_list[sched_domain];



		spin_lock(&kcq->lock);

		trace_block_rq_insert(rq);

		if (at_head)

			list_move(&rq->queuelist, head);

		else

			list_move_tail(&rq->queuelist, head);

		sbitmap_set_bit(&khd->kcq_map[sched_domain],

				rq->mq_ctx->index_hw[hctx->type]);

		trace_block_rq_insert(rq);

		spin_unlock(&kcq->lock);

	}

}