Commit fb5fabb1 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Kalle Valo
Browse files

mt76: mt7921: remove incorrect error handling 



Clang points out a mistake in the error handling in
mt7921_mcu_tx_rate_report(), which tries to dereference a pointer that
cannot be initialized because of the error that is being handled:

drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:409:3: warning: variable 'stats' is uninitialized when used here [-Wuninitialized]
                stats->tx_rate = rate;
                ^~~~~
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:401:32: note: initialize the variable 'stats' to silence this warning
        struct mt7921_sta_stats *stats;
                                      ^
Just remove the obviously incorrect line.

Fixes: 1c099ab4 ("mt76: mt7921: add MCU support")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210225145953.404859-2-arnd@kernel.org
parent 62541e26

drivers/net/wireless/mediatek/mt76/mt7921/mcu.c

+1 −3
Original line number Diff line number Diff line
@@ -405,10 +405,8 @@ mt7921_mcu_tx_rate_report(struct mt7921_dev *dev, struct sk_buff *skb, 
	if (wlan_idx >= MT76_N_WCIDS)

		return;

	wcid = rcu_dereference(dev->mt76.wcid[wlan_idx]);

	if (!wcid) {

		stats->tx_rate = rate;

	if (!wcid)

		return;

	}



	msta = container_of(wcid, struct mt7921_sta, wcid);

	stats = &msta->stats;