Commit fb27e70f authored by Ben Hutchings's avatar Ben Hutchings Committed by Masahiro Yamada
Browse files

modpost: Fix processing of CRCs on 32-bit build machines 



modpost now reads CRCs from .*.cmd files, parsing them using strtol().
This is inconsistent with its parsing of Module.symvers and with their
definition as *unsigned* 32-bit values.

strtol() clamps values to [LONG_MIN, LONG_MAX], and when building on a
32-bit system this changes all CRCs >= 0x80000000 to be 0x7fffffff.

Change extract_crcs_for_object() to use strtoul() instead.

Cc: stable@vger.kernel.org
Fixes: f292d875 ("modpost: extract symbol versions from *.cmd files")
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 1073c15f

scripts/mod/modpost.c

+1 −1
Original line number Diff line number Diff line
@@ -1733,7 +1733,7 @@ static void extract_crcs_for_object(const char *object, struct module *mod) 
		if (!isdigit(*p))

			continue;	/* skip this line */



		crc = strtol(p, &p, 0);

		crc = strtoul(p, &p, 0);

		if (*p != '\n')

			continue;	/* skip this line */