Commit fb1eee47 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

netpoll: move netpoll_send_skb() out of line 



There is no need to inline this helper, as we intend to add more
code in this function.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 307f660d

include/linux/netpoll.h

+1 −8
Original line number Diff line number Diff line
@@ -63,14 +63,7 @@ int netpoll_setup(struct netpoll *np); 
void __netpoll_cleanup(struct netpoll *np);

void __netpoll_free(struct netpoll *np);

void netpoll_cleanup(struct netpoll *np);

void __netpoll_send_skb(struct netpoll *np, struct sk_buff *skb);

static inline void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)

{

	unsigned long flags;

	local_irq_save(flags);

	__netpoll_send_skb(np, skb);

	local_irq_restore(flags);

}

void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb);



#ifdef CONFIG_NETPOLL

static inline void *netpoll_poll_lock(struct napi_struct *napi)

net/core/netpoll.c

+11 −2
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ static int netpoll_owner_active(struct net_device *dev) 
}



/* call with IRQ disabled */

void __netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)

static void __netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)

{

	netdev_tx_t status = NETDEV_TX_BUSY;

	struct net_device *dev;
@@ -360,7 +360,16 @@ void __netpoll_send_skb(struct netpoll *np, struct sk_buff *skb) 
		schedule_delayed_work(&npinfo->tx_work,0);

	}

}

EXPORT_SYMBOL(__netpoll_send_skb);



void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)

{

	unsigned long flags;



	local_irq_save(flags);

	__netpoll_send_skb(np, skb);

	local_irq_restore(flags);

}

EXPORT_SYMBOL(netpoll_send_skb);



void netpoll_send_udp(struct netpoll *np, const char *msg, int len)

{