Commit fb05b14c authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

debugfs: remove return value of debugfs_create_ulong() 

No one checks the return value of debugfs_create_ulong(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20210521184340.1348539-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 393b0638

fs/debugfs/file.c

+4 −14
Original line number Diff line number Diff line
@@ -582,22 +582,12 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_ulong_wo, NULL, debugfs_ulong_set, "%llu\n"); 
 * This function creates a file in debugfs with the given name that

 * contains the value of the variable @value.  If the @mode variable is so

 * set, it can be read from, and written to.

 *

 * This function will return a pointer to a dentry if it succeeds.  This

 * pointer must be passed to the debugfs_remove() function when the file is

 * to be removed (no automatic cleanup happens if your module is unloaded,

 * you are responsible here.)  If an error occurs, ERR_PTR(-ERROR) will be

 * returned.

 *

 * If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will

 * be returned.

 */

struct dentry *debugfs_create_ulong(const char *name, umode_t mode,

				    struct dentry *parent, unsigned long *value)

void debugfs_create_ulong(const char *name, umode_t mode, struct dentry *parent,

			  unsigned long *value)

{

	return debugfs_create_mode_unsafe(name, mode, parent, value,

					&fops_ulong, &fops_ulong_ro,

					&fops_ulong_wo);

	debugfs_create_mode_unsafe(name, mode, parent, value, &fops_ulong,

				   &fops_ulong_ro, &fops_ulong_wo);

}

EXPORT_SYMBOL_GPL(debugfs_create_ulong);

include/linux/debugfs.h

+5 −9
Original line number Diff line number Diff line
@@ -112,8 +112,8 @@ void debugfs_create_u32(const char *name, umode_t mode, struct dentry *parent, 
			u32 *value);

void debugfs_create_u64(const char *name, umode_t mode, struct dentry *parent,

			u64 *value);

struct dentry *debugfs_create_ulong(const char *name, umode_t mode,

				    struct dentry *parent, unsigned long *value);

void debugfs_create_ulong(const char *name, umode_t mode, struct dentry *parent,

			  unsigned long *value);

void debugfs_create_x8(const char *name, umode_t mode, struct dentry *parent,

		       u8 *value);

void debugfs_create_x16(const char *name, umode_t mode, struct dentry *parent,
@@ -266,13 +266,9 @@ static inline void debugfs_create_u32(const char *name, umode_t mode, 
static inline void debugfs_create_u64(const char *name, umode_t mode,

				      struct dentry *parent, u64 *value) { }



static inline struct dentry *debugfs_create_ulong(const char *name,

						umode_t mode,

static inline void debugfs_create_ulong(const char *name, umode_t mode,

					struct dentry *parent,

						unsigned long *value)

{

	return ERR_PTR(-ENODEV);

}

					unsigned long *value) { }



static inline void debugfs_create_x8(const char *name, umode_t mode,

				     struct dentry *parent, u8 *value) { }