Commit fadb74f9 authored Jun 01, 2023 by Lucas De Marchi Committed by Luis Chamberlain Jun 01, 2023

module/decompress: Fix error checking on zstd decompression



While implementing support for in-kernel decompression in kmod,
finit_module() was returning a very suspicious value:

	finit_module(3, "", MODULE_INIT_COMPRESSED_FILE) = 18446744072717407296

It turns out the check for module_get_next_page() failing is wrong,
and hence the decompression was not really taking place. Invert
the condition to fix it.

Fixes: 169a58ad ("module/decompress: Support zstd in-kernel decompression")
Cc: stable@kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

parent db3e33dd

kernel/module/decompress.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -257,7 +257,7 @@ static ssize_t module_zstd_decompress(struct load_info *info,
		do {
		struct page *page = module_get_next_page(info);

		if (!IS_ERR(page)) {
		if (IS_ERR(page)) {
		retval = PTR_ERR(page);
		goto out;
		}