Commit fad48d84 authored by Kai Ye's avatar Kai Ye Committed by Marcel Holtmann
Browse files

Bluetooth: a2mp: Use the correct print format 



According to Documentation/core-api/printk-formats.rst,
Use the correct print format. Printing an unsigned int value should use %u
instead of %d. Otherwise printk() might end up displaying negative numbers.

Signed-off-by: default avatarKai Ye <yekai13@huawei.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 658d5d80

net/bluetooth/a2mp.c

+12 −12
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ static int a2mp_command_rej(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (le16_to_cpu(hdr->len) < sizeof(*rej))

		return -EINVAL;



	BT_DBG("ident %d reason %d", hdr->ident, le16_to_cpu(rej->reason));

	BT_DBG("ident %u reason %d", hdr->ident, le16_to_cpu(rej->reason));



	skb_pull(skb, sizeof(*rej));
@@ -219,7 +219,7 @@ static int a2mp_discover_rsp(struct amp_mgr *mgr, struct sk_buff *skb, 


	cl = (void *) skb->data;

	while (len >= sizeof(*cl)) {

		BT_DBG("Remote AMP id %d type %d status %d", cl->id, cl->type,

		BT_DBG("Remote AMP id %u type %u status %u", cl->id, cl->type,

		       cl->status);



		if (cl->id != AMP_ID_BREDR && cl->type != AMP_TYPE_BREDR) {
@@ -273,7 +273,7 @@ static int a2mp_change_notify(struct amp_mgr *mgr, struct sk_buff *skb, 
	struct a2mp_cl *cl = (void *) skb->data;



	while (skb->len >= sizeof(*cl)) {

		BT_DBG("Controller id %d type %d status %d", cl->id, cl->type,

		BT_DBG("Controller id %u type %u status %u", cl->id, cl->type,

		       cl->status);

		cl = skb_pull(skb, sizeof(*cl));

	}
@@ -302,7 +302,7 @@ static int a2mp_getinfo_req(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (le16_to_cpu(hdr->len) < sizeof(*req))

		return -EINVAL;



	BT_DBG("id %d", req->id);

	BT_DBG("id %u", req->id);



	hdev = hci_dev_get(req->id);

	if (!hdev || hdev->dev_type != HCI_AMP) {
@@ -344,7 +344,7 @@ static int a2mp_getinfo_rsp(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (le16_to_cpu(hdr->len) < sizeof(*rsp))

		return -EINVAL;



	BT_DBG("id %d status 0x%2.2x", rsp->id, rsp->status);

	BT_DBG("id %u status 0x%2.2x", rsp->id, rsp->status);



	if (rsp->status)

		return -EINVAL;
@@ -373,7 +373,7 @@ static int a2mp_getampassoc_req(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (le16_to_cpu(hdr->len) < sizeof(*req))

		return -EINVAL;



	BT_DBG("id %d", req->id);

	BT_DBG("id %u", req->id);



	/* Make sure that other request is not processed */

	tmp = amp_mgr_lookup_by_state(READ_LOC_AMP_ASSOC);
@@ -423,7 +423,7 @@ static int a2mp_getampassoc_rsp(struct amp_mgr *mgr, struct sk_buff *skb, 


	assoc_len = len - sizeof(*rsp);



	BT_DBG("id %d status 0x%2.2x assoc len %zu", rsp->id, rsp->status,

	BT_DBG("id %u status 0x%2.2x assoc len %zu", rsp->id, rsp->status,

	       assoc_len);



	if (rsp->status)
@@ -457,7 +457,7 @@ static int a2mp_getampassoc_rsp(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (!hcon)

		goto done;



	BT_DBG("Created hcon %p: loc:%d -> rem:%d", hcon, hdev->id, rsp->id);

	BT_DBG("Created hcon %p: loc:%u -> rem:%u", hcon, hdev->id, rsp->id);



	mgr->bredr_chan->remote_amp_id = rsp->id;
@@ -481,7 +481,7 @@ static int a2mp_createphyslink_req(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (le16_to_cpu(hdr->len) < sizeof(*req))

		return -EINVAL;



	BT_DBG("local_id %d, remote_id %d", req->local_id, req->remote_id);

	BT_DBG("local_id %u, remote_id %u", req->local_id, req->remote_id);



	memset(&rsp, 0, sizeof(rsp));
@@ -562,7 +562,7 @@ static int a2mp_discphyslink_req(struct amp_mgr *mgr, struct sk_buff *skb, 
	if (le16_to_cpu(hdr->len) < sizeof(*req))

		return -EINVAL;



	BT_DBG("local_id %d remote_id %d", req->local_id, req->remote_id);

	BT_DBG("local_id %u remote_id %u", req->local_id, req->remote_id);



	memset(&rsp, 0, sizeof(rsp));
@@ -599,7 +599,7 @@ static int a2mp_discphyslink_req(struct amp_mgr *mgr, struct sk_buff *skb, 
static inline int a2mp_cmd_rsp(struct amp_mgr *mgr, struct sk_buff *skb,

			       struct a2mp_cmd *hdr)

{

	BT_DBG("ident %d code 0x%2.2x", hdr->ident, hdr->code);

	BT_DBG("ident %u code 0x%2.2x", hdr->ident, hdr->code);



	skb_pull(skb, le16_to_cpu(hdr->len));

	return 0;
@@ -620,7 +620,7 @@ static int a2mp_chan_recv_cb(struct l2cap_chan *chan, struct sk_buff *skb) 
		hdr = (void *) skb->data;

		len = le16_to_cpu(hdr->len);



		BT_DBG("code 0x%2.2x id %d len %u", hdr->code, hdr->ident, len);

		BT_DBG("code 0x%2.2x id %u len %u", hdr->code, hdr->ident, len);



		skb_pull(skb, sizeof(*hdr));