Commit fa586abc authored by Qing Wang's avatar Qing Wang Committed by Thierry Reding
Browse files

firmware: tegra: Switch over to memdup_user() 



This patch fixes the following Coccinelle warning:

drivers/firmware/tegra/bpmp-debugfs.c:379: WARNING opportunity for memdup_user

Use memdup_user() rather than duplicating its implementation. This is a
little bit restricted to reduce false positives.

Signed-off-by: default avatarQing Wang <wangqing@vivo.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 568035b0

drivers/firmware/tegra/bpmp-debugfs.c

+3 −10
Original line number Diff line number Diff line
@@ -377,18 +377,11 @@ static ssize_t bpmp_debug_store(struct file *file, const char __user *buf, 
	if (!filename)

		return -ENOENT;



	databuf = kmalloc(count, GFP_KERNEL);

	if (!databuf)

		return -ENOMEM;



	if (copy_from_user(databuf, buf, count)) {

		err = -EFAULT;

		goto free_ret;

	}

	databuf = memdup_user(buf, count);

	if (IS_ERR(databuf))

		return PTR_ERR(databuf);



	err = mrq_debug_write(bpmp, filename, databuf, count);



free_ret:

	kfree(databuf);



	return err ?: count;