Commit fa51b16d authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: idxd: fix calling wq quiesce inside spinlock 



Dan reports that smatch has found idxd_wq_quiesce() is being called inside
the idxd->dev_lock. idxd_wq_quiesce() calls wait_for_completion() and
therefore it can sleep. Move the call outside of the spinlock as it does
not need device lock.

Fixes: 5b0c68c4 ("dmaengine: idxd: support reporting of halt interrupt")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/163716858508.1721911.15051495873516709923.stgit@djiang5-desk3.ch.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1ffc6f35

drivers/dma/idxd/irq.c

+1 −1
Original line number Diff line number Diff line
@@ -137,10 +137,10 @@ static int process_misc_interrupts(struct idxd_device *idxd, u32 cause) 
			INIT_WORK(&idxd->work, idxd_device_reinit);

			queue_work(idxd->wq, &idxd->work);

		} else {

			spin_lock(&idxd->dev_lock);

			idxd->state = IDXD_DEV_HALTED;

			idxd_wqs_quiesce(idxd);

			idxd_wqs_unmap_portal(idxd);

			spin_lock(&idxd->dev_lock);

			idxd_device_clear_state(idxd);

			dev_err(&idxd->pdev->dev,

				"idxd halted, need %s.\n",