Commit fa4bb7d3 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab
Browse files

media: ov8856: Check reading clock frequency succeeded 



Instead of blindly trusting getting the clock frequency succeeded end then
testing it against a pre-defined value, verify reading the value
succeeded.

Fixes: 879347f0 ("media: ov8856: Add support for OV8856 sensor")
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent bf27502b

drivers/media/i2c/ov8856.c

+4 −1
Original line number Diff line number Diff line
@@ -1106,7 +1106,10 @@ static int ov8856_check_hwcfg(struct device *dev) 
	if (!fwnode)

		return -ENXIO;



	fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);

	ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);

	if (ret)

		return ret;



	if (mclk != OV8856_MCLK) {

		dev_err(dev, "external clock %d is not supported", mclk);

		return -EINVAL;