Commit fa451399 authored by Sean Young's avatar Sean Young Committed by Miquel Raynal
Browse files

mtd: rfd_ftl: use container_of() rather than cast 



The container_of() is much more readable and also safer.

Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210807214538.14484-6-sean@mess.org
parent d056f8cd

drivers/mtd/rfd_ftl.c

+7 −7
Original line number Diff line number Diff line
@@ -239,7 +239,7 @@ static int scan_header(struct partition *part) 


static int rfd_ftl_readsect(struct mtd_blktrans_dev *dev, u_long sector, char *buf)

{

	struct partition *part = (struct partition*)dev;

	struct partition *part = container_of(dev, struct partition, mbd);

	u_long addr;

	size_t retlen;

	int rc;
@@ -600,7 +600,7 @@ static int find_free_sector(const struct partition *part, const struct block *bl 


static int do_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf, ulong *old_addr)

{

	struct partition *part = (struct partition*)dev;

	struct partition *part = container_of(dev, struct partition, mbd);

	struct block *block;

	u_long addr;

	int i;
@@ -666,7 +666,7 @@ static int do_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf, 


static int rfd_ftl_writesect(struct mtd_blktrans_dev *dev, u_long sector, char *buf)

{

	struct partition *part = (struct partition*)dev;

	struct partition *part = container_of(dev, struct partition, mbd);

	u_long old_addr;

	int i;

	int rc = 0;
@@ -708,7 +708,7 @@ static int rfd_ftl_writesect(struct mtd_blktrans_dev *dev, u_long sector, char * 
static int rfd_ftl_discardsect(struct mtd_blktrans_dev *dev,

			       unsigned long sector, unsigned int nr_sects)

{

	struct partition *part = (struct partition *)dev;

	struct partition *part = container_of(dev, struct partition, mbd);

	u_long addr;

	int rc;
@@ -735,7 +735,7 @@ static int rfd_ftl_discardsect(struct mtd_blktrans_dev *dev, 


static int rfd_ftl_getgeo(struct mtd_blktrans_dev *dev, struct hd_geometry *geo)

{

	struct partition *part = (struct partition*)dev;

	struct partition *part = container_of(dev, struct partition, mbd);



	geo->heads = 1;

	geo->sectors = SECTORS_PER_TRACK;
@@ -792,7 +792,7 @@ static void rfd_ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd) 


static void rfd_ftl_remove_dev(struct mtd_blktrans_dev *dev)

{

	struct partition *part = (struct partition*)dev;

	struct partition *part = container_of(dev, struct partition, mbd);

	int i;



	for (i=0; i<part->total_blocks; i++) {
@@ -803,7 +803,7 @@ static void rfd_ftl_remove_dev(struct mtd_blktrans_dev *dev) 
	vfree(part->sector_map);

	kfree(part->header_cache);

	kfree(part->blocks);

	del_mtd_blktrans_dev(dev);

	del_mtd_blktrans_dev(&part->mbd);

}



static struct mtd_blktrans_ops rfd_ftl_tr = {