Commit fa2f921f authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

devlink: don't use strcpy() to copy param value 



No need to treat string params any different comparing to other types.
Rely on the struct assign to copy the whole struct, including the
string.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 170677fe

net/devlink/leftover.c

+3 −12
Original line number Diff line number Diff line
@@ -4387,9 +4387,6 @@ static int __devlink_nl_cmd_param_set_doit(struct devlink *devlink, 
		return -EOPNOTSUPP;



	if (cmode == DEVLINK_PARAM_CMODE_DRIVERINIT) {

		if (param->type == DEVLINK_PARAM_TYPE_STRING)

			strcpy(param_item->driverinit_value.vstr, value.vstr);

		else

		param_item->driverinit_value = value;

		param_item->driverinit_value_valid = true;

	} else {
@@ -9655,9 +9652,6 @@ int devl_param_driverinit_value_get(struct devlink *devlink, u32 param_id, 
						      DEVLINK_PARAM_CMODE_DRIVERINIT)))

		return -EOPNOTSUPP;



	if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)

		strcpy(init_val->vstr, param_item->driverinit_value.vstr);

	else

	*init_val = param_item->driverinit_value;



	return 0;
@@ -9689,9 +9683,6 @@ void devl_param_driverinit_value_set(struct devlink *devlink, u32 param_id, 
						      DEVLINK_PARAM_CMODE_DRIVERINIT)))

		return;



	if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)

		strcpy(param_item->driverinit_value.vstr, init_val.vstr);

	else

	param_item->driverinit_value = init_val;

	param_item->driverinit_value_valid = true;