Commit fa1d43f3 authored by Gleb Chesnokov's avatar Gleb Chesnokov Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Remove unused qla_sess_op_cmd_list from scsi_qla_host_t 

The qla_sess_op_cmd_list was introduced in commit 8b2f5ff3 ("qla2xxx:
cleanup cmd in qla workqueue before processing TMR"). Then the usage of
this list was dropped in commit fb35265b ("scsi: qla2xxx: Remove
session creation redundant code").

Thus, remove this list since it is no longer used.

Link: https://lore.kernel.org/r/AS8PR10MB49524AAB4C8016E4AFF17FFB9D2D9@AS8PR10MB4952.EURPRD10.PROD.OUTLOOK.COM


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarGleb Chesnokov <Chesnokov.G@raidix.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 106b7a25

drivers/scsi/qla2xxx/qla_def.h

+0 −1
Original line number Diff line number Diff line
@@ -4917,7 +4917,6 @@ typedef struct scsi_qla_host { 


	/* list of commands waiting on workqueue */

	struct list_head	qla_cmd_list;

	struct list_head	qla_sess_op_cmd_list;

	struct list_head	unknown_atio_list;

	spinlock_t		cmd_list_lock;

	struct delayed_work	unknown_atio_work;

drivers/scsi/qla2xxx/qla_os.c

+0 −1
Original line number Diff line number Diff line
@@ -4962,7 +4962,6 @@ struct scsi_qla_host *qla2x00_create_host(struct scsi_host_template *sht, 
	INIT_LIST_HEAD(&vha->work_list);

	INIT_LIST_HEAD(&vha->list);

	INIT_LIST_HEAD(&vha->qla_cmd_list);

	INIT_LIST_HEAD(&vha->qla_sess_op_cmd_list);

	INIT_LIST_HEAD(&vha->logo_list);

	INIT_LIST_HEAD(&vha->plogi_ack_list);

	INIT_LIST_HEAD(&vha->qp_list);

drivers/scsi/qla2xxx/qla_target.c

+0 −20
Original line number Diff line number Diff line
@@ -2024,17 +2024,6 @@ static void abort_cmds_for_lun(struct scsi_qla_host *vha, u64 lun, be_id_t s_id) 


	key = sid_to_key(s_id);

	spin_lock_irqsave(&vha->cmd_list_lock, flags);

	list_for_each_entry(op, &vha->qla_sess_op_cmd_list, cmd_list) {

		uint32_t op_key;

		u64 op_lun;



		op_key = sid_to_key(op->atio.u.isp24.fcp_hdr.s_id);

		op_lun = scsilun_to_int(

			(struct scsi_lun *)&op->atio.u.isp24.fcp_cmnd.lun);

		if (op_key == key && op_lun == lun)

			op->aborted = true;

	}



	list_for_each_entry(op, &vha->unknown_atio_list, cmd_list) {

		uint32_t op_key;

		u64 op_lun;
@@ -4726,15 +4715,6 @@ static int abort_cmds_for_s_id(struct scsi_qla_host *vha, port_id_t *s_id) 
	       ((u32)s_id->b.al_pa));



	spin_lock_irqsave(&vha->cmd_list_lock, flags);

	list_for_each_entry(op, &vha->qla_sess_op_cmd_list, cmd_list) {

		uint32_t op_key = sid_to_key(op->atio.u.isp24.fcp_hdr.s_id);



		if (op_key == key) {

			op->aborted = true;

			count++;

		}

	}



	list_for_each_entry(op, &vha->unknown_atio_list, cmd_list) {

		uint32_t op_key = sid_to_key(op->atio.u.isp24.fcp_hdr.s_id);