Commit fa182ea2 authored by Divya Koppera's avatar Divya Koppera Committed by Jakub Kicinski
Browse files

net: phy: micrel: Fixes FIELD_GET assertion 



FIELD_GET() must only be used with a mask that is a compile-time
constant. Mark the functions as __always_inline to avoid the problem.

Fixes: 21b688da ("net: phy: micrel: Cable Diag feature for lan8814 phy")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarDivya Koppera <Divya.Koppera@microchip.com>
Link: https://lore.kernel.org/r/20221011095437.12580-1-Divya.Koppera@microchip.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3c186054

drivers/net/phy/micrel.c

+5 −4
Original line number Diff line number Diff line
@@ -1838,7 +1838,7 @@ static int ksz886x_cable_test_start(struct phy_device *phydev) 
	return phy_clear_bits(phydev, MII_BMCR, BMCR_ANENABLE | BMCR_SPEED100);

}



static int ksz886x_cable_test_result_trans(u16 status, u16 mask)

static __always_inline int ksz886x_cable_test_result_trans(u16 status, u16 mask)

{

	switch (FIELD_GET(mask, status)) {

	case KSZ8081_LMD_STAT_NORMAL:
@@ -1854,13 +1854,13 @@ static int ksz886x_cable_test_result_trans(u16 status, u16 mask) 
	}

}



static bool ksz886x_cable_test_failed(u16 status, u16 mask)

static __always_inline bool ksz886x_cable_test_failed(u16 status, u16 mask)

{

	return FIELD_GET(mask, status) ==

		KSZ8081_LMD_STAT_FAIL;

}



static bool ksz886x_cable_test_fault_length_valid(u16 status, u16 mask)

static __always_inline bool ksz886x_cable_test_fault_length_valid(u16 status, u16 mask)

{

	switch (FIELD_GET(mask, status)) {

	case KSZ8081_LMD_STAT_OPEN:
@@ -1871,7 +1871,8 @@ static bool ksz886x_cable_test_fault_length_valid(u16 status, u16 mask) 
	return false;

}



static int ksz886x_cable_test_fault_length(struct phy_device *phydev, u16 status, u16 data_mask)

static __always_inline int ksz886x_cable_test_fault_length(struct phy_device *phydev,

							   u16 status, u16 data_mask)

{

	int dt;