Commit fa165e19 authored by Edward Cree's avatar Edward Cree Committed by Jakub Kicinski
Browse files

sfc: don't unregister flow_indr if it was never registered 



In efx_init_tc(), move the setting of efx->tc->up after the
 flow_indr_dev_register() call, so that if it fails, efx_fini_tc()
 won't call flow_indr_dev_unregister().

Fixes: 5b2e12d5 ("sfc: bind indirect blocks for TC offload on EF100")
Suggested-by: default avatarPieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Reviewed-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: default avatarEdward Cree <ecree.xilinx@gmail.com>
Link: https://lore.kernel.org/r/a81284d7013aba74005277bd81104e4cfbea3f6f.1692114888.git.ecree.xilinx@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 23d775f1

drivers/net/ethernet/sfc/tc.c

+1 −1
Original line number Diff line number Diff line
@@ -1657,10 +1657,10 @@ int efx_init_tc(struct efx_nic *efx) 
	rc = efx_tc_configure_fallback_acts_reps(efx);

	if (rc)

		return rc;

	efx->tc->up = true;

	rc = flow_indr_dev_register(efx_tc_indr_setup_cb, efx);

	if (rc)

		return rc;

	efx->tc->up = true;

	return 0;

}