Unverified Commit fa0f3db4 authored by Xingbang Liu's avatar Xingbang Liu Committed by Mark Brown
Browse files

spi: qup: replace spin_lock_irqsave by spin_lock in hard IRQ 



The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.

Signed-off-by: default avatarXingbang Liu <liu.airalert@gmail.com>
Link: https://lore.kernel.org/r/20220302071521.6638-1-liu.airalert@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c59dbc64

drivers/spi/spi-qup.c

+2 −3
Original line number Diff line number Diff line
@@ -593,7 +593,6 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) 
{

	struct spi_qup *controller = dev_id;

	u32 opflags, qup_err, spi_err;

	unsigned long flags;

	int error = 0;



	qup_err = readl_relaxed(controller->base + QUP_ERROR_FLAGS);
@@ -625,10 +624,10 @@ static irqreturn_t spi_qup_qup_irq(int irq, void *dev_id) 
		error = -EIO;

	}



	spin_lock_irqsave(&controller->lock, flags);

	spin_lock(&controller->lock);

	if (!controller->error)

		controller->error = error;

	spin_unlock_irqrestore(&controller->lock, flags);

	spin_unlock(&controller->lock);



	if (spi_qup_is_dma_xfer(controller->mode)) {

		writel_relaxed(opflags, controller->base + QUP_OPERATIONAL);