Commit f9fdb0b8 authored by Liang He's avatar Liang He Committed by Vinod Koul
Browse files

dmaengine: ti: k3-udma-private: Fix refcount leak bug in of_xudma_dev_get() 



We should call of_node_put() for the reference returned by
of_parse_phandle() in fail path or when it is not used anymore.
Here we only need to move the of_node_put() before the check.

Fixes: d7024191 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
Signed-off-by: default avatarLiang He <windhl@126.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20220720073234.1255474-1-windhl@126.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8f2b6bc7

drivers/dma/ti/k3-udma-private.c

+3 −3
Original line number Diff line number Diff line
@@ -31,14 +31,14 @@ struct udma_dev *of_xudma_dev_get(struct device_node *np, const char *property) 
	}



	pdev = of_find_device_by_node(udma_node);

	if (np != udma_node)

		of_node_put(udma_node);



	if (!pdev) {

		pr_debug("UDMA device not found\n");

		return ERR_PTR(-EPROBE_DEFER);

	}



	if (np != udma_node)

		of_node_put(udma_node);



	ud = platform_get_drvdata(pdev);

	if (!ud) {

		pr_debug("UDMA has not been probed\n");