Commit f9ea8d6e authored by Dan Carpenter's avatar Dan Carpenter Committed by Liu Chuang
Browse files

Input: synaptics-rmi4 - fix use after free in rmi_unregister_function() 

stable inclusion
from stable-v5.10.201
commit 6c71e065befb2fae8f1461559b940c04e1071bd5
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9RFE5
CVE: CVE-2023-52840

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=6c71e065befb2fae8f1461559b940c04e1071bd5



----------------------------------------------------------------------

[ Upstream commit eb988e46da2e4eae89f5337e047ce372fe33d5b1 ]

The put_device() calls rmi_release_function() which frees "fn" so the
dereference on the next line "fn->num_of_irqs" is a use after free.
Move the put_device() to the end to fix this.

Fixes: 24d28e4f ("Input: synaptics-rmi4 - convert irq distribution to irq_domain")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/706efd36-7561-42f3-adfa-dd1d0bd4f5a1@moroto.mountain


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLiu Chuang <liuchuang40@huawei.com>
parent 051f4691

drivers/input/rmi4/rmi_bus.c

+1 −1
Original line number Diff line number Diff line
@@ -276,11 +276,11 @@ void rmi_unregister_function(struct rmi_function *fn) 


	device_del(&fn->dev);

	of_node_put(fn->dev.of_node);

	put_device(&fn->dev);



	for (i = 0; i < fn->num_of_irqs; i++)

		irq_dispose_mapping(fn->irq[i]);



	put_device(&fn->dev);

}



/**