Commit f9c0cf8f authored by Jason A. Donenfeld's avatar Jason A. Donenfeld Committed by Guenter Roeck
Browse files

hwmon: (sht4x) do not overflow clamping operation on 32-bit platforms 



On 32-bit platforms, long is 32 bits, so (long)UINT_MAX is less than
(long)SHT4X_MIN_POLL_INTERVAL, which means the clamping operation is
bogus. Fix this by clamping at INT_MAX, so that the upperbound is the
same on all platforms.

Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Link: https://lore.kernel.org/r/20220924101151.4168414-1-Jason@zx2c4.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 1b2f9b1e

drivers/hwmon/sht4x.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ static int sht4x_read_values(struct sht4x_data *data) 


static ssize_t sht4x_interval_write(struct sht4x_data *data, long val)

{

	data->update_interval = clamp_val(val, SHT4X_MIN_POLL_INTERVAL, UINT_MAX);

	data->update_interval = clamp_val(val, SHT4X_MIN_POLL_INTERVAL, INT_MAX);



	return 0;

}