Commit f999e23c authored by Mark Pearson's avatar Mark Pearson Committed by Hans de Goede
Browse files

platform/x86: thinkpad_acpi: Fix lkp-tests warnings for platform profiles 



Fix issues identified in dytc_profile_refresh identified by lkp-tests.
drivers/platform/x86/thinkpad_acpi.c:10538
	dytc_profile_refresh() error: uninitialized symbol 'funcmode'.
drivers/platform/x86/thinkpad_acpi.c:10531
	dytc_profile_refresh() error: uninitialized symbol 'output'.
drivers/platform/x86/thinkpad_acpi.c:10537
	dytc_profile_refresh() error: uninitialized symbol 'output'.

These issues should not lead to real problems in the field as the refresh
function should only be called if MMC or PSC mode enabled. But good to fix.

Thanks to Dan Carpenter and the lkp-tests project for flagging these.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202306011202.1hbgLRD4-lkp@intel.com/


Fixes: 1bc5d819 ("platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms")
Signed-off-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Link: https://lore.kernel.org/r/20230606151804.8819-1-mpearson-lenovo@squebb.ca


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 2515e542

drivers/platform/x86/thinkpad_acpi.c

+4 −2
Original line number Diff line number Diff line
@@ -10524,8 +10524,8 @@ static int dytc_profile_set(struct platform_profile_handler *pprof, 
static void dytc_profile_refresh(void)

{

	enum platform_profile_option profile;

	int output, err = 0;

	int perfmode, funcmode;

	int output = 0, err = 0;

	int perfmode, funcmode = 0;



	mutex_lock(&dytc_mutex);

	if (dytc_capabilities & BIT(DYTC_FC_MMC)) {
@@ -10538,6 +10538,8 @@ static void dytc_profile_refresh(void) 
		err = dytc_command(DYTC_CMD_GET, &output);

		/* Check if we are PSC mode, or have AMT enabled */

		funcmode = (output >> DYTC_GET_FUNCTION_BIT) & 0xF;

	} else { /* Unknown profile mode */

		err = -ENODEV;

	}

	mutex_unlock(&dytc_mutex);

	if (err)