Commit f97e6e1e authored by Alex Dewar's avatar Alex Dewar Committed by Martin K. Petersen
Browse files

scsi: aic7xxx: Use kmemdup() in two places 

kmemdup() can be used instead of kmalloc()+memcpy(). Replace two
occurrences of this pattern.

Issue identified with Coccinelle.

Link: https://lore.kernel.org/r/20200909185855.151964-1-alex.dewar90@gmail.com


Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent beef6fd0

drivers/scsi/aic7xxx/aic79xx_core.c

+1 −2
Original line number Diff line number Diff line
@@ -9402,10 +9402,9 @@ ahd_loadseq(struct ahd_softc *ahd) 
	if (cs_count != 0) {



		cs_count *= sizeof(struct cs);

		ahd->critical_sections = kmalloc(cs_count, GFP_ATOMIC);

		ahd->critical_sections = kmemdup(cs_table, cs_count, GFP_ATOMIC);

		if (ahd->critical_sections == NULL)

			panic("ahd_loadseq: Could not malloc");

		memcpy(ahd->critical_sections, cs_table, cs_count);

	}

	ahd_outb(ahd, SEQCTL0, PERRORDIS|FAILDIS|FASTMODE);

drivers/scsi/aic7xxx/aic7xxx_core.c

+1 −2
Original line number Diff line number Diff line
@@ -6879,10 +6879,9 @@ ahc_loadseq(struct ahc_softc *ahc) 
	if (cs_count != 0) {



		cs_count *= sizeof(struct cs);

		ahc->critical_sections = kmalloc(cs_count, GFP_ATOMIC);

		ahc->critical_sections = kmemdup(cs_table, cs_count, GFP_ATOMIC);

		if (ahc->critical_sections == NULL)

			panic("ahc_loadseq: Could not malloc");

		memcpy(ahc->critical_sections, cs_table, cs_count);

	}

	ahc_outb(ahc, SEQCTL, PERRORDIS|FAILDIS|FASTMODE);