Commit f96c9f30 authored by NeilBrown's avatar NeilBrown
Browse files

md/raid0: improve error message when converting RAID4-with-spares to RAID0 



Mentioning "bad disk number -1" exposes irrelevant internal detail.
Just say they are inactive and must be removed.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 58ebb34c

drivers/md/raid0.c

+7 −1
Original line number Diff line number Diff line
@@ -175,7 +175,13 @@ static int create_strip_zones(struct mddev *mddev, struct r0conf **private_conf) 
			rdev1->new_raid_disk = j;

		}



		if (j < 0 || j >= mddev->raid_disks) {

		if (j < 0) {

			printk(KERN_ERR

			       "md/raid0:%s: remove inactive devices before converting to RAID0\n",

			       mdname(mddev));

			goto abort;

		}

		if (j >= mddev->raid_disks) {

			printk(KERN_ERR "md/raid0:%s: bad disk number %d - "

			       "aborting!\n", mdname(mddev), j);

			goto abort;