Commit f9315f17 authored Oct 03, 2023 by Bartosz Golaszewski

gpio: aspeed: fix the GPIO number passed to pinctrl_gpio_set_config()



pinctrl_gpio_set_config() expects the GPIO number from the global GPIO
numberspace, not the controller-relative offset, which needs to be added
to the chip base.

Fixes: 5ae4cb94 ("gpio: aspeed: Add debounce support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>

parent f0575116

drivers/gpio/gpio-aspeed.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
		else if (param == PIN_CONFIG_BIAS_DISABLE \|\|
		param == PIN_CONFIG_BIAS_PULL_DOWN \|\|
		param == PIN_CONFIG_DRIVE_STRENGTH)
		return pinctrl_gpio_set_config(offset, config);
		return pinctrl_gpio_set_config(chip->base + offset, config);
		else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN \|\|
		param == PIN_CONFIG_DRIVE_OPEN_SOURCE)
		/* Return -ENOTSUPP to trigger emulation, as per datasheet */