Commit f91958cc authored by Shannon Nelson's avatar Shannon Nelson Committed by David S. Miller
Browse files

ionic: tame the filter no space message 



Override the automatic AdminQ error message in order to
capture the potential No Space message when we hit the
max vlan limit, and add additional messaging to detail
what filter failed.

Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8c9d956a

drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c

+14 −1
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ static int ionic_lif_filter_add(struct ionic_lif *lif, 
	}



	if (err != -ENOSPC)

		err = ionic_adminq_post_wait(lif, &ctx);

		err = ionic_adminq_post_wait_nomsg(lif, &ctx);



	spin_lock_bh(&lif->rx_filters.lock);
@@ -382,6 +382,19 @@ static int ionic_lif_filter_add(struct ionic_lif *lif, 
			return 0;

		}



		ionic_adminq_netdev_err_print(lif, ctx.cmd.cmd.opcode,

					      ctx.comp.comp.status, err);

		switch (le16_to_cpu(ctx.cmd.rx_filter_add.match)) {

		case IONIC_RX_FILTER_MATCH_VLAN:

			netdev_info(lif->netdev, "rx_filter add failed: VLAN %d\n",

				    ctx.cmd.rx_filter_add.vlan.vlan);

			break;

		case IONIC_RX_FILTER_MATCH_MAC:

			netdev_info(lif->netdev, "rx_filter add failed: ADDR %pM\n",

				    ctx.cmd.rx_filter_add.mac.addr);

			break;

		}



		return err;

	}