Commit f914bfdd authored by Rob Herring's avatar Rob Herring Committed by Rafael J. Wysocki
Browse files

cpuidle: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Acked-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Acked-by: default avatarAnup Patel <anup@brainfault.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 197b6b60

drivers/cpuidle/cpuidle-psci-domain.c

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev) 
	 * initialize a genpd/genpd-of-provider pair when it's found.

	 */

	for_each_child_of_node(np, node) {

		if (!of_find_property(node, "#power-domain-cells", NULL))

		if (!of_property_present(node, "#power-domain-cells"))

			continue;



		ret = psci_pd_init(node, use_osi);

drivers/cpuidle/cpuidle-riscv-sbi.c

+3 −3
Original line number Diff line number Diff line
@@ -497,7 +497,7 @@ static int sbi_genpd_probe(struct device_node *np) 
	 * initialize a genpd/genpd-of-provider pair when it's found.

	 */

	for_each_child_of_node(np, node) {

		if (!of_find_property(node, "#power-domain-cells", NULL))

		if (!of_property_present(node, "#power-domain-cells"))

			continue;



		ret = sbi_pd_init(node);
@@ -548,8 +548,8 @@ static int sbi_cpuidle_probe(struct platform_device *pdev) 
	for_each_possible_cpu(cpu) {

		np = of_cpu_device_node_get(cpu);

		if (np &&

		    of_find_property(np, "power-domains", NULL) &&

		    of_find_property(np, "power-domain-names", NULL)) {

		    of_property_present(np, "power-domains") &&

		    of_property_present(np, "power-domain-names")) {

			continue;

		} else {

			sbi_cpuidle_use_osi = false;