Commit f91140e4 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Eric W. Biederman
Browse files

soc: ti: fix wkup_m3_rproc_boot_thread return type 



The wkup_m3_rproc_boot_thread() function uses a nonstandard prototype,
which broke after Eric's recent cleanup:

drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
  429 |         return 0;
      |                ^
drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
  416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~

Change it to the normal prototype as it should have been from the
start.

Fixes: 111e7049 ("exit/kthread: Have kernel threads return instead of calling do_exit")
Fixes: cdd5de50 ("soc: ti: Add wkup_m3_ipc driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org


Acked-by: default avatarSantosh Shilimkar <ssantosh@kernel.org>
Acked-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
parent 00b06da2

drivers/soc/ti/wkup_m3_ipc.c

+3 −2
Original line number Diff line number Diff line
@@ -413,8 +413,9 @@ void wkup_m3_ipc_put(struct wkup_m3_ipc *m3_ipc) 
}

EXPORT_SYMBOL_GPL(wkup_m3_ipc_put);



static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)

static int wkup_m3_rproc_boot_thread(void *arg)

{

	struct wkup_m3_ipc *m3_ipc = arg;

	struct device *dev = m3_ipc->dev;

	int ret;
@@ -500,7 +501,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) 
	 * can boot the wkup_m3 as soon as it's ready without holding

	 * up kernel boot

	 */

	task = kthread_run((void *)wkup_m3_rproc_boot_thread, m3_ipc,

	task = kthread_run(wkup_m3_rproc_boot_thread, m3_ipc,

			   "wkup_m3_rproc_loader");



	if (IS_ERR(task)) {