Commit f9002510 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Takashi Iwai
Browse files

ALSA: hda: hdac_ext_controller: remove useless loop 



commit 0b00a561 ("ALSA: hdac_ext: add hdac extended controller")
introduced a for() loop on the number of HDaudio codecs that seems
completely useless.

a) the body of the loop does not make use of the loop index, and
b) the LSDIID register is related to the SDI line, so there can only
be one codec per multi-link descriptor.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20221019162115.185917-10-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 26646c19

sound/hda/ext/hdac_ext_controller.c

+2 −4
Original line number Diff line number Diff line
@@ -135,10 +135,8 @@ EXPORT_SYMBOL_GPL(snd_hdac_ext_link_free_all); 
struct hdac_ext_link *snd_hdac_ext_bus_get_hlink_by_addr(struct hdac_bus *bus, int addr)

{

	struct hdac_ext_link *hlink;

	int i;



	list_for_each_entry(hlink, &bus->hlink_list, list)

		for (i = 0; i < HDA_MAX_CODECS; i++)

		if (hlink->lsdiid & (0x1 << addr))

			return hlink;

	return NULL;