Commit f8cb556f authored by Dan Carpenter's avatar Dan Carpenter Committed by Jan Kara
Browse files

ext3: remove unneeded check in ext3_ordered_writepage() 



We already know "ret" is zero so there is no need to do:

		if (!ret)
			ret = err;

We can just assign ret directly instead.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 7d6c2113

fs/ext3/inode.c

+2 −5
Original line number Diff line number Diff line
@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page, 
	 * block_write_full_page() succeeded.  Otherwise they are unmapped,

	 * and generally junk.

	 */

	if (ret == 0) {

		err = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,

	if (ret == 0)

		ret = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,

					NULL, journal_dirty_data_fn);

		if (!ret)

			ret = err;

	}

	walk_page_buffers(handle, page_bufs, 0,

			PAGE_CACHE_SIZE, NULL, bput_one);

	err = ext3_journal_stop(handle);